a suspected bug in nfs_free_seqid()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi. I found a suspected bug while I review nfs_free_seqid() in nfs4state.c

It seems that nfs_free_seqid() tried to use "test and test-set" idiom
(double checked locking)
but the second "test" is missed so that It may occur data race when
other thread makes
&seqid->list not empty before the thread executiong nfs_free_seqid()
holds spin_lock(&sequence->lock) after checking !list_empty(&seqid->list).

I do not have much background for nfs so that it might not be a real bug
so please review the code and let me know whether it is real one or not.
Thanks.

Sincerely,
Shin Hong
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux