On Wed, Jan 07, 2009 at 02:42:56AM -0500, Christoph Hellwig wrote: > On Tue, Jan 06, 2009 at 07:28:16PM -0500, J. Bruce Fields wrote: > > On Tue, Jan 06, 2009 at 04:23:28PM -0800, Andrew Morton wrote: > > > On Tue, 6 Jan 2009 19:15:01 -0500 > > > "J. Bruce Fields" <bfields@xxxxxxxxxxxx> wrote: > > > > > > > nfsd: fix double-locks of directory mutex > > > > > > grumble. > > > > This is literally just a revert of part of 4c728ef583b3d822; if you'd > > like me to clean up this stuff while I'm there, I'm happy to. > > Please leave it as the revert. NFSD really needs to use vfs_fsync > eventually so we can sort out our ->fsync usage. OK. Mind if we just revert the whole commit for now? With the double-lock regression is still there for ecryptfs exports, then I'd rather do a simple revert of the whole patch and not try to pick out just the fs/nfsd/vfs.c part. --b. > I suspect the best way to get there is to to the i_mutex removal for > fsync earlier than planned, but I'll need to audit the filesystems > first. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
