On Mon, Dec 29, 2008 at 12:04:29PM -0500, Chuck Lever wrote: > On Dec 24, 2008, at Dec 24, 2008, 11:15 PM, J. Bruce Fields wrote: >> On Fri, Dec 12, 2008 at 04:57:42PM -0500, Chuck Lever wrote: >>> Clean up: I'd like to refactor __write_ports() to make it easier to >>> understand and maintain. Introduce a set of helper functions to >>> handle the details of the __write_ports() function. >>> >>> New helpers are not used yet. >> >> As stated in http://marc.info/?l=linux-nfs&m=122894134032274&w=2, I'd >> prefer that new code be introduced with its callers where reasonable, >> so >> in this case I'd rather this patch be combined with the following. > > Right, I wrote these patches well before the referenced e-mail, and > split them this way because the diff of the combined changes is well- > nigh impossible to read. > > What I may end up doing instead is splitting these helpers out one patch > at a time. That should make for more legible patches. Yes, I think that's the more natural split. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
