On Wed, Dec 10, 2008 at 04:10:41PM -0500, Chuck Lever wrote: > > On Dec 10, 2008, at Dec 10, 2008, 4:05 PM, J. Bruce Fields wrote: > >> On Fri, Dec 05, 2008 at 07:02:53PM -0500, Chuck Lever wrote: >>> Introduce some dprintk() calls in fs/lockd/mon.c that are enabled by >>> the NLMDBG_MONITOR flag. These report when we find, create, and >>> release nsm_handles. >>> >>> Since printk() can sleep, these are placed outside the nsm_lock >>> spinlock. >> >> Nope, printk() is designed to be callable from anywhere. (This is >> documented e.g. in kernel/printk.c:printk().) I've applied the >> following; look OK? > > That's fine, but it will make applying later patches more difficult. > > I can fix this up in my repo and resend subsequent patches if you like, > or you can just delete that last sentence in the description, and apply > this patch as is. Yeah, already applied, figuring it'd save a round trip. I think you'd told me before you preferred fixing up yourself and resending, and I'd forgotten; I'll try to remember that next time. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
