On Sat, Dec 06, 2008 at 08:44:02AM -0500, Steve Dickson wrote:
> In my recent trials and tribulations on dealing with
> the state file I found this fairly obvious bug:
Yipes. This code needs all the eyes it can get, I guess.
--b.
>
> commit 5d8b800b8438222a55c4698c86b558b15717aa21
> Author: Steve Dickson <steved@xxxxxxxxxx>
> Date: Sat Dec 6 08:31:29 2008 -0500
>
> sm-notify: always exiting without any notification
>
> Added curly brackets around the record_pid() check which
> stops sm-notify from exiting when a pid file does not
> exist.
>
> Signed-off-by: Steve Dickson <steved@xxxxxxxxxx>
>
> diff --git a/utils/statd/sm-notify.c b/utils/statd/sm-notify.c
> index 7a7ae1a..d8e2c01 100644
> --- a/utils/statd/sm-notify.c
> +++ b/utils/statd/sm-notify.c
> @@ -193,10 +193,11 @@ usage: fprintf(stderr,
> openlog("sm-notify", LOG_PID, LOG_DAEMON);
>
> if (strcmp(_SM_BASE_PATH, BASEDIR) == 0) {
> - if (record_pid() == 0 && force == 0 && opt_update_state == 1)
> + if (record_pid() == 0 && force == 0 && opt_update_state == 1) {
> /* already run, don't try again */
> nsm_log(LOG_NOTICE, "Already notifying clients; Exiting!");
> exit(0);
> + }
> }
>
> if (opt_srcaddr) {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
