Re: [PATCH 1/1] NFS: map nfs_probe_fsinfo errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2008-12-04 at 12:09 -0500, andros@xxxxxxxxxx wrote:
> From: Andy Adamson <andros@xxxxxxxxxx>
> 
> Callers of nfs_probe_fsinfo return ERR_PTR errors. NFSv4 errors need to be
> mapped.
> 
> Signed-off-by: Andy Adamson <andros@xxxxxxxxxx>
> ---
>  fs/nfs/client.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/nfs/client.c b/fs/nfs/client.c
> index 7547600..e12495c 100644
> --- a/fs/nfs/client.c
> +++ b/fs/nfs/client.c
> @@ -817,7 +817,7 @@ static int nfs_probe_fsinfo(struct nfs_server *server, struct nfs_fh *mntfh, str
>  
>  out_error:
>  	dprintk("nfs_probe_fsinfo: error = %d\n", -error);
> -	return error;
> +	return nfs4_map_errors(error);
>  }
>  
>  /*

No. This is still in generic code that is also called by both NFSv2 and
v3. We should _never_ be passing NFSv4 errors this far up the stack.

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@xxxxxxxxxx
www.netapp.com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux