On Wed, Dec 03, 2008 at 07:38:07PM -0500, Chuck Lever wrote: > It's cleared in nlm_host_rebooted(), and in nsm_unmonitor(). > > The nlm_host_mutex already provides much the same serialization that is > added in this patch, and at least on the server, nlm_lookup_host() and > nlm_destroy_host() both run under the BKL. > > The problem (if there is one) is really in nlm_host_rebooted(), which > this patch does nothing about. > > Let's drop this one for now. I think there is a way to get rpc.statd to > report duplicates instead of ignoring them as it does now. We should get > an idea of how pervasive this problem really is. OK, fair enough. I think it's a good catch, though, and one other motivation is that *someday* (after fixing a bunch of similar locking problems) it would be convenient if lockd could be made multithreaded. And if we haven't seen this particular problem in practice, part of the reason may be that lockd is single-threaded and entirely under the BKL. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
