On Wed, Dec 03, 2008 at 02:34:04PM -0500, bfields wrote:
> On Mon, Dec 01, 2008 at 01:57:42PM -0500, Chuck Lever wrote:
> > --- a/include/linux/lockd/lockd.h
> > +++ b/include/linux/lockd/lockd.h
> > @@ -75,7 +75,7 @@ struct nsm_handle {
> > size_t sm_addrlen;
> > unsigned int sm_monitored : 1,
> > sm_sticky : 1; /* don't unmonitor */
> > - char sm_addrbuf[48]; /* address eyecatcher */
> > + char sm_addrbuf[63]; /* presentation address */
> > };
>
> Could you add a brief (1-line?) comment justifying the choice of 63?
So something like just:
sm_sticky : 1; /* don't unmonitor */
unsigned int sm_monitored : 1,
sm_sticky : 1; /* don't unmonitor */
/*
* This can hold 8 groups of colon-separated 4-hex-digit numbers, a
* percent sign, and a scope id (at most 32 bits, in decimal, so):
* 63 == 8*4 + 7 colons + 1 percent sign + at most 10 digits + padding:
*/
char sm_addrbuf[63]; /* presentation address */
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
