On Nov. 10, 2008, 22:05 +0200, Benny Halevy <bhalevy@xxxxxxxxxxx> wrote: > 3 call sites look at hdr.status before returning success. > hdr.status must be zero in this case so there's no point in this. > > Currently, hdr.status is correctly processed at decode_op_hdr time > if the op status cannot be decoded. review 11-14: send to Trond > > Signed-off-by: Benny Halevy <bhalevy@xxxxxxxxxxx> > --- > fs/nfs/nfs4xdr.c | 6 ------ > 1 files changed, 0 insertions(+), 6 deletions(-) > > diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c > index ac2386b..69b5a56 100644 > --- a/fs/nfs/nfs4xdr.c > +++ b/fs/nfs/nfs4xdr.c > @@ -4423,8 +4423,6 @@ static int nfs4_xdr_dec_fsinfo(struct rpc_rqst *req, __be32 *p, struct nfs_fsinf > status = decode_putfh(&xdr); > if (!status) > status = decode_fsinfo(&xdr, fsinfo); > - if (!status) > - status = nfs4_stat_to_errno(hdr.status); > return status; > } > > @@ -4513,8 +4511,6 @@ static int nfs4_xdr_dec_setclientid(struct rpc_rqst *req, __be32 *p, > status = decode_compound_hdr(&xdr, &hdr); > if (!status) > status = decode_setclientid(&xdr, clp); > - if (!status) > - status = nfs4_stat_to_errno(hdr.status); > return status; > } > > @@ -4535,8 +4531,6 @@ static int nfs4_xdr_dec_setclientid_confirm(struct rpc_rqst *req, __be32 *p, str > status = decode_putrootfh(&xdr); > if (!status) > status = decode_fsinfo(&xdr, fsinfo); > - if (!status) > - status = nfs4_stat_to_errno(hdr.status); > return status; > } > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
