On Mon, 2008-11-10 at 15:26 -0500, J. Bruce Fields wrote: > Yep. And when we're in that situation, last_close is true, so > > if (last_close && ops->release_pipe) > ops->release_pipe(inode) > > does ensure that calls to the ->open_pipe() and ->release_pipe() methods > balance, as originally claimed. > > Maybe it'd be clearer to call that variable "still_open", or something? > > still_open = rpci->nreaders != 0 || rpci->nwriters != 0; > ... > if (still_open && ops->release_pipe) > ops->release_pipe(inode) Call it 'need_release'. It is definitely confusing right now... -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
