[PATCH 02/12] lockd: kill redundant host->h_server check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Note that the first argument to nlmsvc_is_client always has h_server
set, since it is the host associated with a lock, block, or share held
by the server.

Signed-off-by: J. Bruce Fields <bfields@xxxxxxxxxxxxxx>
---
 fs/lockd/svcsubs.c |   19 +++++++++----------
 1 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/fs/lockd/svcsubs.c b/fs/lockd/svcsubs.c
index 34c2766..9c186f0 100644
--- a/fs/lockd/svcsubs.c
+++ b/fs/lockd/svcsubs.c
@@ -335,16 +335,15 @@ nlmsvc_is_client(void *data, struct nlm_host *dummy)
 {
 	struct nlm_host *host = data;
 
-	if (host->h_server) {
-		/* we are destroying locks even though the client
-		 * hasn't asked us too, so don't unmonitor the
-		 * client
-		 */
-		if (host->h_nsmhandle)
-			host->h_nsmhandle->sm_sticky = 1;
-		return 1;
-	} else
-		return 0;
+	BUG_ON(!host->h_server);
+	/* we are destroying locks even though the client
+	 * hasn't asked us too, so don't unmonitor the
+	 * client
+	 */
+	if (host->h_nsmhandle)
+		host->h_nsmhandle->sm_sticky = 1;
+	return 1;
+
 }
 
 /*
-- 
1.5.5.rc1

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux