On Thu, Oct 23, 2008 at 02:48:44PM -0400, Jeff Layton wrote: > I've been reviewing a patch for CIFS, and out of the discussions over > that patch, there's been the recommendation to not set sk_sndbuf and > sk_rcvbuf. Apparently, setting these to a value will place a hard limit > on the buffer sizes for the socket, so there's not much need to set > these unless we want to limit memory usage to this value for some > reason. > > One question is that the sunrpc code sets these values in > svc_sock_setbufsize(). What is the reasoning behind this? > > If we're doing it to limit memory consumption then that's certainly > valid, but if we're doing this to attempt to make sure that we have > "enough" buffer space for the expected load then this may be > counter-productive. Yep! See http://marc.info/?l=linux-nfs&m=122461390600382&w=2 and followups; Olga and Jim have found this makes a huge difference to performance on fast high-latency networks. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
