On Thu, Oct 23, 2008 at 11:17:37AM -0400, Olga Kornievskaia wrote: > J. Bruce Fields wrote: >> Could we get a really brief summary of the performance improvement for a >> high-speed network, to include in the commit message? >> > Here's a pick from some LAN performance #s: w/o 237479Mb/s => w/ 343669Mb/s. That's on a 1G network? (With what ping time?) > Are you asking for svc_sock_setbufsize() function in svcsock.c to be > moved to svc_xprt.c? Why? It really belongs in svcsock.c with the rest > of the socket management code. This fragment: >>> lock_sock(sock->sk); >>> sock->sk->sk_sndbuf = snd * 2; >>> sock->sk->sk_rcvbuf = rcv * 2; >>> - sock->sk->sk_userlocks |= SOCK_SNDBUF_LOCK|SOCK_RCVBUF_LOCK; >>> release_sock(sock->sk); should really be part of the core networking (not sunrpc) code. That's been a todo for a while. It doesn't necessarily have to be done as a prerequisite to this patch. But we should try to do it. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
