J. Bruce Fields wrote:
Could we get a really brief summary of the performance improvement for a
high-speed network, to include in the commit message?
I don't have before and after numbers for this patch. But an earlier
version boosted write performance from 432 to 15859 KBps on a transatlantic
link with 120ms rtt. That's with 16 slot table entries.
The one remaining worry I recall is that we assume the tcp autotuning
never decreases the size of the buffer below the size we initially
requested. Apparently that assumption is true. There's some worry
about whether that's true by design or merely true of the current
implementation.
That's true now but it's mostly an accident of the implementation.
That doesn't look like a big worry--I'm inclined to apply this patch as
is--but moving the sk_{rcv,snd}buf assignments to a simple function in
the networking code and documenting the requirements there might be a
nice thing to do (as a separate patch).
That's the right thing to do. NFS shouldn't be reaching in to the sock
struct data fields. I started to write such a patch but got bogged down.
Should it be a socket function, implemented by all the transports, or a tcp
only function?
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
