From: Krishna Kumar <krkumar2@xxxxxxxxxx> Rewrite error case to not check twice for !buflen. Compile tested. Signed-off-by: Krishna Kumar <krkumar2@xxxxxxxxxx> --- fs/nfsd/vfs.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff -ruNp linux-2.6.27.org/fs/nfsd/vfs.c linux-2.6.27.new/fs/nfsd/vfs.c --- linux-2.6.27.org/fs/nfsd/vfs.c 2008-10-20 10:47:19.000000000 +0530 +++ linux-2.6.27.new/fs/nfsd/vfs.c 2008-10-20 10:48:32.000000000 +0530 @@ -503,10 +503,11 @@ _get_posix_acl(struct dentry *dentry, ch int buflen; buflen = nfsd_getxattr(dentry, key, &buf); - if (!buflen) - buflen = -ENODATA; - if (buflen <= 0) + if (buflen <= 0) { + if (!buflen) + buflen = -ENODATA; return ERR_PTR(buflen); + } pacl = posix_acl_from_xattr(buf, buflen); kfree(buf); -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html