On Wed, Oct 15, 2008 at 08:14:57AM -0400, Jeff Layton wrote: > From the descriptions in those commits, it looks like the check > in svc_check_conn_limits was intended to prevent messages from too > many sockets overloading the receive buffers. Aren't the receive buffers per-connection? --b. > We size the UDP receive buffers by the number of threads: > > (serv->sv_nrthreads+3) * serv->sv_max_mesg > > TCP receive buffers are statically sized fairly small and don't ever > seem to change since sv_max_mesg is pretty much set at server > creation time: > > 3 * serv->sv_max_mesg > > ...the comments in svc_tcp_recvfrom explain the reason for it. > > Given all of this, it seems reasonable to eliminate the check > entirely for TCP. For UDP, it looks like we expect that 1 buffer > can handle up to 20 connections. I'm not sure where this ratio > comes from though... > > Anyone else have thoughts on this? > > -- > Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html