On Oct 8, 2008, at 1:56 PM, Trond Myklebust wrote:
On Wed, 2008-10-08 at 10:55 -0400, Chuck Lever wrote:
Just a note...
Peter Staubach (I think) suggested NFS4_SETCLIENTID_NAMELEN should be
a slightly smaller value to prevent the compiler from adding wasted
space in the structure to align these fields.
If nothing else, you can safely make NFS4_SETCLIENTID_NAMELEN 127
instead of 128.
Done...
Oh, in case you need it....
Acked-by: Chuck Lever <chuck.lever@xxxxxxxxxx>
---------------------------------------------------------------------
From: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>
Date: Wed, 8 Oct 2008 13:54:52 -0400
NFS: Save padding bytes in struct nfs4_setclientid
Peter Staubach suggested reducing NFS4_SETCLIENTID_NAMELEN by one
byte so
as to avoid 7 bytes of unnecessary padding.
Signed-off-by: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>
---
include/linux/nfs_xdr.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/nfs_xdr.h b/include/linux/nfs_xdr.h
index f6e95bf..6ee6ae3 100644
--- a/include/linux/nfs_xdr.h
+++ b/include/linux/nfs_xdr.h
@@ -672,7 +672,7 @@ struct nfs4_rename_res {
struct nfs_fattr * new_fattr;
};
-#define NFS4_SETCLIENTID_NAMELEN (128)
+#define NFS4_SETCLIENTID_NAMELEN (127)
struct nfs4_setclientid {
const nfs4_verifier * sc_verifier;
unsigned int sc_name_len;
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@xxxxxxxxxx
www.netapp.com
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
