On Wed, 2008-10-08 at 13:40 -0400, Talpey, Thomas wrote: > At 01:31 PM 10/8/2008, Trond Myklebust wrote: > >On Wed, 2008-10-08 at 11:48 -0400, Tom Talpey wrote: > >> The mount system call path does not expect such errors as ECONNREFUSED > >> to be returned from failed transport connection attempts, otherwise it > >> prints simply "internal error". Translate all such errors to ENOTCONN > >> from RPC/RDMA to match sockets behavior. > > > >Hmm... Shouldn't we be passing the ECONNREFUSED error here, and rather > >fix the downstream error paths? > > That means fixing /sbin/mount.nfs, and an earlier conversation concluded that > "doing what TCP does" was preferred. The error path from NFS and RPC is, > frankly, more than a little tortuous. The error is translated and filtered in > both layers, after being returned from the transport. Then, the mount command > makes up its own diagnostic from what comes back from the syscall. Well beyond > the scope of RDMA. > > Your call. As proposed, it is more compatible with current practice, IMO. Are you saying that mount.nfs translates 'ECONNREFUSED' as 'internal error'? That would be a bug... Trond -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
