Confused about 'sloppy' option parsing in NFS.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The kernel used by OpenSUSE-11.0 complains when automount passes a
'grpid' option.  So I'm looking at backporting the 'sloppy' option
parsing fix.  But I'm confused.

Looking at commit f45663ce5fb30f76a3414ab3ac69f4dd320e760a

It introduced 'sloppy' and 'errors' in nfs_parse_mount_options,
possibly sets them to some non-zero value based on what it finds, and
then does absolutely nothing with them.

nfs_parse_mount_options only returns zero if:
  - memalloc fails
  - security_sb_parse_opts_str fails

But never if there is an unrecognised argument.

This functionality is obviously quite trivial to backport, but I
wonder if it is correct.

Is it just a simple slip up, or am I missing something?

Thanks,
NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux