On Fri, Aug 15, 2008 at 5:04 PM, Trond Myklebust <Trond.Myklebust@xxxxxxxxxx> wrote: > On Fri, 2008-08-15 at 16:47 -0400, Trond Myklebust wrote: >> On Fri, 2008-08-15 at 16:34 -0400, Chuck Lever wrote: >> > Trond, NFS_MOUNT_FLAGMASK is used in nfs_init_server() and >> > nfs4_init_server() for both legacy binary and text-based mounts. This >> > needs to be moved to a legacy-only path if we want to use the >> > high-order 16 bits in the 'flags' field for text-based mounts. >> >> We definitely want to do this. The point of introducing text-based >> mounts was to allow us to add functionality without having to worry >> about legacy binary mount formats. The mask should be there in order to >> ensure that binary formats don't start enabling features that they >> cannot support. There is no justification for applying it to the text >> mount path. > > I've attached the patch... Thanks! -- "Officer. Ma'am. Squeaker." -- Mr. Incredible -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html