On Tue, Aug 12, 2008 at 08:44:41PM +0300, Benny Halevy wrote: > nfsd4_encode_open first reservation is currently for 36 + sizeof(stateid_t) > while it writes after the stateid a cinfo (20 bytes) and 5 more 4-bytes > words, for a total of 40 + sizeof(stateid_t). Thanks, yep. I wish this was all a little more automated! --b. > > Signed-off-by: Benny Halevy <bhalevy@xxxxxxxxxxx> > --- > fs/nfsd/nfs4xdr.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c > index cfe9d5c..4ec52f9 100644 > --- a/fs/nfsd/nfs4xdr.c > +++ b/fs/nfsd/nfs4xdr.c > @@ -2142,7 +2142,7 @@ nfsd4_encode_open(struct nfsd4_compoundres *resp, __be32 nfserr, struct nfsd4_op > if (nfserr) > goto out; > > - RESERVE_SPACE(36 + sizeof(stateid_t)); > + RESERVE_SPACE(40 + sizeof(stateid_t)); > WRITE32(open->op_stateid.si_generation); > WRITEMEM(&open->op_stateid.si_opaque, sizeof(stateid_opaque_t)); > WRITECINFO(open->op_cinfo); > -- > 1.5.6.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html