On Tue, 15 Jul 2008 14:45:54 -0400 "J. Bruce Fields" <bfields@xxxxxxxxxxxx> wrote: > On Sat, Jul 12, 2008 at 09:17:10AM -0400, Jeff Layton wrote: > > Both nlmsvc_lock and nlmsvc_testlock call nlmsvc_lookup_host to find a > > nlm_host struct. All the callers of these functions, however, call > > nlmsvc_retrieve_args or nlm4svc_retrieve_args which also return a > > nlm_host struct. > > > > Change nlmsvc_lock and nlmsvc_testlock to take a host arg instead of > > calling nlmsvc_lookup_host themselves and change the callers to pass > > a pointer to the nlm_host they've already found. > > That makes sense to me, thanks. > > > Also, get rid of some unneeded nlm_host NULL checks. > > > > I think I've got the reference counting right with this patch, but > > I wouldn't mind someone sanity checking it. > > So, the way I do that sanity-checking is by breaking up the individual > changes as finely as I can, as follows.... > > --b. Thanks Bruce, The patchset in your for-2.6.27 branch looks fine to me. Cheers, -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
