On Tue, Jul 08, 2008 at 11:16:49AM +0300, Benny Halevy wrote: > On Jul. 07, 2008, 22:25 +0300, "J. Bruce Fields" <bfields@xxxxxxxxxxxx> wrote: > > Yes, this looks correct, at least for the immediate fix; thanks! > > > > Eventually I think we should move to opening a new file descriptor when > > upgrading, and keeping two file descriptors with the stateid; I think > > this business of trying to use a file descriptor for write when we > > opened it for read is probably wrong. > > That could work, though they need to be associated in some way > for open_downgrade/close processing. Yes. I think it would work just to keep up to one read-only open and one write-only open and then close one or the other as necessary on the downgrade. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html