On Thu, June 5, 2008 9:40 pm, Scott Atchley wrote:
> On Jun 5, 2008, at 1:00 AM, Neil Brown wrote:
>
>> That will, of course, report the "nfsd" mount as well, which we don't
>> want. So let's try again.
>>
>> NeilBrown
>>
>>
>> diff --git a/utils/nfsstat/nfsstat.c b/utils/nfsstat/nfsstat.c
>> index aa6c961..d2cca8d 100644
>> --- a/utils/nfsstat/nfsstat.c
>> +++ b/utils/nfsstat/nfsstat.c
>> @@ -716,7 +716,7 @@ mounts(const char *name)
>> if (!(type = strtok(NULL, " \t")))
>> continue;
>>
>> - if (strcmp(type, "nfs")) {
>> + if (strcmp(type, "nfs") && strcmp(type,"nfs4")) {
>> continue;
>> }
>
> Don't you want an OR?
>
> + if (strcmp(type, "nfs") || strcmp(type,"nfs4")) {
Thanks for reviewing the patch (always appreciated), but no - I don't
want OR.
What I really want is to eradicate all usages of
if (strcmp(X,Y))
in the world and make them
if (strcmp(X,Y) != 0)
Then it is clearer that it is a "!=" test.
In this case, the condition as I had it means"
If type is not nfs and type is not nfs4
(then continue)
which is what I want.
Your version says:
If type is not nfs or type is not nfs4
and that will always be true.
+ if (strcmp(type, "nfs") != 0 && strcmp(type, "nfs4") != 0)) {
NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
