On Sun, May 25, 2008 at 03:01:12PM -0400, bfields wrote: > On Fri, May 23, 2008 at 10:39:53AM -0500, Tom Tucker wrote: > > The ib_sge is used to store both dma_addr_t and virtual addresses. > > This causes a warning on 32b platforms when casting ptrs to the > > u64 addr field of the ib_sge. There is work underway to reduce the > > memory footprint of the WR context in 2.6.27 the time frame that will > > remove the overloading of the ib_sge.addr field. > > Naively, this and "svcrdma: Refactor RDMA_WRITE dma mapping logic" still > look like a step in the wrong direction; the old code seemed to have a > much more clear separation between kernel addresses (void *'s) and > on-the-wire addresses (stored in u64's). Stuff like: > > > + (void*)(unsigned long) > > + sge[i].addr, sge[i].length, > > makes me nervous. That aside, are those two patches really bugfixes? We need to keep bugfixes (for 2.6.26) separate from other stuff (for 2.6.27). --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
