knfsd is the last NFS-related kernel thread that does not use the
kthread API. This patchset represents a first pass at converting it. It
seems to work, but changes the shutdown interface. knfsd currently
allows signals to tell it when to come down.
My main question is...how tied to this shutdown method are we? We can
also take down nfsd by having people run:
# rpc.nfsd 0
...which basically does:
# echo 0 > /proc/fs/nfsd/threads
...so we don't think we *have* to use signals here. Is signaling
something we can reasonably eliminate? In addition to making the code a
bit simpler and cleaner, I think it will also eliminate this race:
http://lkml.org/lkml/2007/8/2/462
If this isn't feasible, then I can add the signaling back in, but am not
sure whether we can eliminate the race without adding more locking.
If we can do this, we may need to provide an alternate way to specify
that we want to take down all nfsd's but not flush the export table.
Currently that's done with a SIGHUP, but the value of this facility is
not clear to me since the kernel can just do another upcall.
Comments and suggestions appreciated...
Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
