On May 16, 2008, at 12:53 PM, J. Bruce Fields wrote:
On Sat, May 10, 2008 at 09:07:23PM -0400, david m. richter wrote:
On Sat, May 10, 2008 at 7:50 PM, Chuck Lever
<chuck.lever@xxxxxxxxxx> wrote:
On May 10, 2008, at 10:32 AM, Trond Myklebust wrote:
On Fri, 2008-05-09 at 19:29 -0700, Chuck Lever wrote:
Should you use in4_pton() instead?
Can we rather convert this to use nfs_parse_server_address? We
don't
need 10 different ways to parse text addresses...
I'm OK with that, as long as there isn't a technical problem with
using
in4_pton().
nfs_parse_server_address() uses in4_pton(), it just also groks ipv6.
This is all a bit orthogonal to the actual bug, as all those functions
want null-terminated strings too.
We could apply the below (compile-tested only) and then add ipv6
support
and converting to nfs_parse_server_address() in a subsequent patch.
It might make more sense to use the utility conversion functions that
are already provided, but just guarantee that we always pass them a
null-terminated string.
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
