Re: [PATCH] text-based mounts should check statd if "lock" is specified

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday May 12, chucklever@xxxxxxxxx wrote:
> From: Neil Brown <neilb@xxxxxxx>
> 
> Make the text-based mount path check whether statd is running if the "lock"
> option is in effect.  This echoes similar logic in the legacy mount path.
> 
> Signed-off-by: Neil Brown <neilb@xxxxxxx>
> Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx>
> ---
> 
> I tried out your patch today, and it caused mounts to fail silently.
> 
> As part of the fix, I reversed the return codes for verify_lock_option to
> match the other helpers, and added a documenting comment.
> 
> Does this look OK?


Yes,  an all-round improvement.
Thanks.
NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux