On Mon, 5 May 2008, J. Bruce Fields wrote:
On Sat, May 03, 2008 at 01:49:20AM +0200, Sten Spans wrote:
I've been trying to get /etc/netgroup support going on
a machine serving nfs mounts to hosts located in various
.nl netblocks. Managing hosts this way greatly simplifies
hosts.allow and exports management, easily worth any slowdowns
during mounting.
I did notice a small problem in the tcpwrapper support:
(resulting in errors from mountd)
127 /* Check the official name first. */
128 if (hosts_ctl(daemon, "", hp->h_name, ""))
129 return 1;
this supplies the resolved hostname in the address field of hosts_ctl
which doesn't work. Changing it to:
if (hosts_ctl(daemon, hp->h_name, "", ""))
does work as expected. The h_aliases check on line 133 probably needs
the same change to work as expected.
Yep; looks like a clear bugfix. (If you have a moment to generate a
patch (with diff -u) showing both changes, that would probably help
Here ya go (attached as well)
--- support/misc/tcpwrapper.c.orig 2008-05-05 17:22:41.887757664 +0200
+++ support/misc/tcpwrapper.c 2008-05-05 17:24:08.857111820 +0200
@@ -125,12 +125,12 @@
return 0;
/* Check the official name first. */
- if (hosts_ctl(daemon, "", hp->h_name, ""))
+ if (hosts_ctl(daemon, hp->h_name, "", ""))
return 1;
/* Check aliases. */
for (sp = hp->h_aliases; *sp ; sp++) {
- if (hosts_ctl(daemon, "", *sp, ""))
+ if (hosts_ctl(daemon, *sp, "", ""))
return 1;
}
--
Sten Spans
"There is a crack in everything, that's how the light gets in."
Leonard Cohen - Anthem--- support/misc/tcpwrapper.c.orig 2008-05-05 17:22:41.887757664 +0200
+++ support/misc/tcpwrapper.c 2008-05-05 17:24:08.857111820 +0200
@@ -125,12 +125,12 @@
return 0;
/* Check the official name first. */
- if (hosts_ctl(daemon, "", hp->h_name, ""))
+ if (hosts_ctl(daemon, hp->h_name, "", ""))
return 1;
/* Check aliases. */
for (sp = hp->h_aliases; *sp ; sp++) {
- if (hosts_ctl(daemon, "", *sp, ""))
+ if (hosts_ctl(daemon, *sp, "", ""))
return 1;
}
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
NFS maillist - NFS@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/nfs
_______________________________________________
Please note that nfs@xxxxxxxxxxxxxxxxxxxxx is being discontinued.
Please subscribe to linux-nfs@xxxxxxxxxxxxxxx instead.
http://vger.kernel.org/vger-lists.html#linux-nfs
