Re: retry= is additive with the text-based mount interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Apr 25, 2008, at 12:59 PM, Steinar H. Gunderson wrote:
On Fri, Apr 25, 2008 at 12:45:36PM -0400, Chuck Lever wrote:
fugl:~# mount -t nfs -v -o retry=0 10.0.0.11:/foo /mnt
mount.nfs: timeout set for Thu Jan  1 14:40:25 1970
mount.nfs: text-based options: 'retry=0,addr=10.0.0.11'
On my test system (Fedora 7) I get correct behavior with both /bin/ mount
and when using /sbin/mount.nfs directly.

It seems the patch has an issue:

+ if (!parse_retry_option(&timeout, options, NFS_DEF_FG_TIMEOUT_MINUTES))

where parse_retry_option() _adds_ to timeout. But timeout is not initialized :-)

Just change "*timeout +=" to "*timeout =" in parse_retry_option().

That was the bug I was trying to fix in the first place.  Sigh.

--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux