Hi Joey-
On Apr 21, 2008, at 12:53 PM, Joey Hess wrote:
Chuck Lever wrote:
What if /etc/mtab is a symlink to a valid writable file that is not /
proc/mounts? The test you introduce below will prevent that case
from
working properly.
Note that util-linux mount does the same thing in this case, so this
must be an uncommon case.
umount.nfs also avoids writing to /etc/mtab if it is a symlink..
In that case, I think the patch description should start out with
"Make mount.nfs handle symlinked /etc/mtab the way umount.nfs and util-
linux handle it." Then the description should explain why this
important.
That provides much better documentation of the change and why it is
needed. Having the util-linux precedent is especially good to know,
and demonstrates that the right homework was done.
Is there a security issue with creating a file in / when /proc isn't
mounted, or is this just an inconvenience?
The worse problem is that mount.nfs fails with a nonzero exit code if
/proc/ is mounted, since the fchmod of /proc/mounts fails.
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
