On Sat, 12 Apr 2008 14:14:47 -0400 Trond Myklebust <trond.myklebust@xxxxxxxxxx> wrote: > > On Sat, 2008-04-12 at 14:09 -0400, Jeff Layton wrote: > > > So how do we tell if a superblock is shared? Is that even possible? > > Aside from the heuristic hint that sb->s_count offers, I don't see how > we can tell. > > > If not, should we just not worry about this and hope for the best? > > That may be the best option. If it is important to people to be able to > change parameters on the fly without disrupting other mountpoints, then > there is always the possibility of mounting with the 'nosharecache' > option. > Ok, then I think my original patch should be sufficient as a fix for remounts not returning error even though they don't apply the new options. BTW: is -EINVAL the correct error for this? Peter is probably correct that we should also consider allowing at least some options to be changed on remount, but I think that would be best addressed by follow-up patches. Thanks for the review so far... -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
