On Fri, 2008-04-11 at 16:03 -0400, Chuck Lever wrote: > To provide compatibility with automounters who use a common set of mount > options for all file systems, change the NFS in-kernel mount option parser > to ignore mount options it doesn't recognize. > > Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx> > --- > Yet another NFS mount patch! Build tested only. Comments? > > fs/nfs/super.c | 7 ++----- > 1 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/fs/nfs/super.c b/fs/nfs/super.c > index f921902..a7201f0 100644 > --- a/fs/nfs/super.c > +++ b/fs/nfs/super.c > @@ -1044,7 +1044,8 @@ static int nfs_parse_mount_options(char *raw, > break; > > default: > - goto out_unknown; > + printk(KERN_INFO "NFS: unrecognized mount option '%s'" > + " ignored\n", p); > } > } > > @@ -1070,10 +1071,6 @@ out_unrec_xprt: > out_unrec_sec: > printk(KERN_INFO "NFS: unrecognized security flavor\n"); > return 0; > - > -out_unknown: > - printk(KERN_INFO "NFS: unknown mount option: %s\n", p); > - return 0; > } > > /* This isn't really a very good solution either. Spamming the syslog on every option that is being ignored isn't going to help the folks with the global automounter maps. Either the rules should be that 'all options are allowed' or they should be that 'only recognised NFS options are allowed'. -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
