On Tue, Mar 18, 2025, at 16:24, Mike Marshall wrote: > Hi Stephen... is there something I should do differently? I might be > using an older > version of the patch, it was sent to me around three weeks ago. > >>>Caused by commit > >> 50fb0a7f43c0 ("orangefs: Move s_kmod_keyword_mask_map to > orangefs-debugfs.c") >>>merging badly with commit > >> 063f8013373a ("orangefs: move s_kmod_keyword_mask_map[] into debugfs.c") > > One has "Move" the one I'm using has "move", as if the author (Arnd) > made an update > to the patch and maybe I missed it...? The earlier patch was from Matthew Wilcox. Our two patches are almost identical (they add the same data in different parts of the file) but sent independently, and the problem was that both got applied instead of just one. I think the easiest fix would be if you just drop my patch from your tree. Arnd