On Wed, Mar 12, 2025 at 06:20:45PM +0100, Greg KH wrote:
> On Wed, Mar 12, 2025 at 10:09:50PM +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the driver-core tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > error[E0599]: no method named `readl` found for reference `&Bar<8>` in the current scope
> > --> drivers/gpu/nova-core/regs.rs:38:18
> > |
> > 38 | Self(bar.readl(BOOT0_OFFSET))
> > | ^^^^^
> > |
> > help: there is a method `read8` with a similar name
> > |
> > 38 | Self(bar.read8(BOOT0_OFFSET))
> > | ~~~~~
> >
> > error: aborting due to 1 previous error
> >
> > For more information about this error, try `rustc --explain E0599`.
> >
> > Caused by commit
> >
> > 354fd6e86fac ("rust: io: rename `io::Io` accessors")
> >
> > interacting with commit
> >
> > 54e6baf123fd ("gpu: nova-core: add initial driver stub")
> >
> > from the drm-nova tree.
> >
> > I applied the following merge fix patch for today.
> >
> > From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> > Date: Wed, 12 Mar 2025 21:36:48 +1100
> > Subject: [PATCH] fix up for "rust: io: rename `io::Io` accessors"
> >
> > interacting with "gpu: nova-core: add initial driver stub"
> >
> > Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> > ---
> > drivers/gpu/nova-core/regs.rs | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/nova-core/regs.rs b/drivers/gpu/nova-core/regs.rs
> > index 50aefb150b0b..b1a25b86ef17 100644
> > --- a/drivers/gpu/nova-core/regs.rs
> > +++ b/drivers/gpu/nova-core/regs.rs
> > @@ -35,7 +35,7 @@
> > impl Boot0 {
> > #[inline]
> > pub(crate) fn read(bar: &Bar0) -> Self {
> > - Self(bar.readl(BOOT0_OFFSET))
> > + Self(bar.read32(BOOT0_OFFSET))
> > }
> >
> > #[inline]
> > --
> > 2.45.2
> >
>
> Fix looks good to me, thanks!
+1, thanks for fixing it up!
