On 2/19/25 17:04, Christian Brauner wrote:
On Wed, Feb 19, 2025 at 03:45:41PM +0700, Bagas Sanjaya wrote:
Separating the bullet list should suffice (plus s/recommend/recommended/
for consistency with the rest of docs):
---- >8 ----
diff --git a/Documentation/filesystems/porting.rst b/Documentation/filesystems/porting.rst
index 3b6622fbd66be9..cfac50a7258db6 100644
--- a/Documentation/filesystems/porting.rst
+++ b/Documentation/filesystems/porting.rst
@@ -1166,10 +1166,11 @@ kern_path_locked() and user_path_locked() no longer return a negative
dentry so this doesn't need to be checked. If the name cannot be found,
ERR_PTR(-ENOENT) is returned.
-** recommend**
+** recommended**
lookup_one_qstr_excl() is changed to return errors in more cases, so
-these conditions don't require explicit checks.
+these conditions don't require explicit checks:
+
- if LOOKUP_CREATE is NOT given, then the dentry won't be negative,
ERR_PTR(-ENOENT) is returned instead
- if LOOKUP_EXCL IS given, then the dentry won't be positive,
Let me know if I should send the formal patch.
No, I'll fix it in-tree and fold it.
Thanks.
OK, thanks!
--
An old man doll... just what I always wanted! - Clara
