On Wed, Feb 12, 2025 at 08:21:41AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> bc0651d93a7b ("xfs: fix online repair probing when CONFIG_XFS_ONLINE_REPAIR=n")
>
> Fixes tag
>
> Fixes: 48a72f60861f79 ("xfs: don't complain about unfixed metadata when repairs were injected")
>
> has these problem(s):
>
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
>
> maybe you meant
>
> Fixes: 48a72f60861f ("xfs: refactor repair forcing tests into a repair.c helper")
>
> or
>
> Fixes: 8336a64eb75c ("xfs: don't complain about unfixed metadata when repairs were injected")
Yes, 8336a64eb75c.
This patch has been on the list for a month now, and nobody complained.
Probably because people aren't good at distinguishing one sequence of
hexadecimal from another.
Could we /please/ have a bot to warn about these annotation problems
when patches are on the list for review, rather than a month later after
it finally enters for-next, without any of the authors, reviewers, or
maintainers having noticed?
Maybe the rest of you are all excellent at this, and I should just fuck
off and quit.
--D
> --
> Cheers,
> Stephen Rothwell
