On Fri, Jan 10, 2025 at 10:34 AM Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> Can I take this as a real patch for my tree? Or is this only an issue
> due to the trees being merged?
The issue appears when the trees are merged, i.e. the code is on its
own OK, though it is also true the code should be using the function
but the macro (even if both work), so you could take the patch as an
independent cleanup to the tree, I guess. In that case, I would clean
the 3 cases (i.e. adding `!` but not removing `kernel::`).
I can also drop a couple bits in `rust-next` and do the cleanup early
next cycle.
Context:
15f2f9313a39 ("rust: use the `build_error!` macro, not the hidden function")
614724e780f5 ("rust: kernel: move `build_error` hidden function to
prevent mistakes")
Thanks!
Cheers,
Miguel
