On 12/3/24 11:33, Mark Brown wrote:
Hi all, After merging the hwmon-staging tree, today's linux-next build (x86 allmodconfig) failed like this: In file included from /tmp/next/build/include/linux/module.h:22, from /tmp/next/build/include/linux/device/driver.h:21, from /tmp/next/build/include/linux/device.h:32, from /tmp/next/build/include/linux/hwmon-sysfs.h:10, from /tmp/next/build/drivers/hwmon/pmbus/tps25990.c:9: /tmp/next/build/drivers/hwmon/pmbus/tps25990.c:437:18: error: expected ',' or ';' before 'PMBUS' 437 | MODULE_IMPORT_NS(PMBUS); | ^~~~~ /tmp/next/build/include/linux/moduleparam.h:26:61: note: in definition of macro '__MODULE_INFO' 26 | = __MODULE_INFO_PREFIX __stringify(tag) "=" info | ^~~~ /tmp/next/build/include/linux/module.h:299:33: note: in expansion of macro 'MODULE_INFO' 299 | #define MODULE_IMPORT_NS(ns) MODULE_INFO(import_ns, ns) | ^~~~~~~~~~~ /tmp/next/build/drivers/hwmon/pmbus/tps25990.c:437:1: note: in expansion of macro 'MODULE_IMPORT_NS' 437 | MODULE_IMPORT_NS(PMBUS); | ^~~~~~~~~~~~~~~~ Caused by an interaction with Linus' tree. I have used the hwmon tree from 20241128 instead.
Yes, that is due to the MODULE_IMPORT_NS API change in the upstream kernel that was pushed right after -rc1. I'll push a new version after I build tested it. Guenter