On Sat, Nov 9, 2024 at 5:55 PM Miguel Ojeda <ojeda@xxxxxxxxxx> wrote: > > The `rust_print` module, when built as a module, fails to build with: > > ERROR: modpost: missing MODULE_LICENSE() in samples/rust/rust_print_events.o > ERROR: modpost: "__tracepoint_rust_sample_loaded" [samples/rust/rust_print.ko] undefined! > ERROR: modpost: "rust_do_trace_rust_sample_loaded" [samples/rust/rust_print.ko] undefined! > > Fix it by building it as a combined one. > > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > Closes: https://lore.kernel.org/all/20241108152149.28459a72@xxxxxxxxxxxxxxxx/ > Fixes: 91d39024e1b0 ("rust: samples: add tracepoint to Rust sample") > Signed-off-by: Miguel Ojeda <ojeda@xxxxxxxxxx> Thanks for fixing this, Miguel! Reviewed-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
