Hi Miguel, On Thu, Nov 07, 2024 at 05:50:50PM +0100, Miguel Ojeda wrote: > On Thu, Nov 7, 2024 at 5:33 PM Eder Zulian <ezulian@xxxxxxxxxx> wrote: > > > > As a note, at the time of writing, RUST support for x86_64 depends on > > !(MITIGATION_RETHUNK && KASAN) || RUSTC_VERSION >= 108300. Miguel Ojeda > > pointed out that this can be avoided with Rust 1.83, to be released in 3 > > weeks (2024-11-28). > > I was referring there to the "or" in that condition, i.e. the "|| > RUSTC_VERSION >= 108300" part. In other words, it was just a comment I > made to explain in the other thread that disabling KASAN or RETHUNK is > not needed anymore when you use 1.83 in the future. :) > Yes, I thought that was clear all along. > But that seems unrelated to the patch here, so normally you wouldn't > add it to the cover letter. Or am I missing something? Same for the > `make rustavailable` note below (i.e. `RUST=y` already implies that). > Noted. I don't think you're missing anything. Thank you for the hints. > (Of course, no need to resend anything for this -- it is just a note > to clarify, and anyway the cover letter does not go into the > repository :) > > Thanks! > > Cheers, > Miguel > Thank you, Eder