On Mon, Oct 28, 2024, at 02:34, Stephen Rothwell wrote: > - } else { > + } else if (IS_ENABLED(CONFIG_HAS_IOPORT)) { > ioaddr = VBE_DISPI_IOPORT_INDEX; > iosize = 2; > - if (!request_region(ioaddr, iosize, "bochs-drm")) { > + if (!devm_request_region(&pdev->dev, ioaddr, iosize, "bochs-drm")) { > DRM_ERROR("Cannot request ioports\n"); > return -EBUSY; Looks good to me, thanks! Arnd