On Fr, 2024-10-25 at 08:44 -0500, Rob Herring wrote:
> On Fri, Oct 25, 2024 at 1:28 AM Herve Codina <herve.codina@xxxxxxxxxxx> wrote:
> >
> > Hi all,
> >
> > On Fri, 25 Oct 2024 11:09:19 +1100
> > Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> >
> > > Hi all,
> > >
> > > After merging the reset tree, today's linux-next build (x86_64
> > > allmodconfig) produced this warning:
> > >
> > > drivers/misc/lan966x_pci.dtso:34.23-40.7: Warning (interrupts_property): /fragment@0/__overlay__/pci-ep-bus@0/oic@e00c0120: Missing interrupt-parent
> > >
> > > Introduced by commit
> > >
> > > 185686beb464 ("misc: Add support for LAN966x PCI device")
> > >
> >
> > This warning is normal.
> > interrupt-parent is not present in the oic node. This was discussed in
> > https://lore.kernel.org/all/CAL_Jsq+je7+9ATR=B6jXHjEJHjn24vQFs4Tvi9=vhDeK9n42Aw@xxxxxxxxxxxxxx/
>
> We can't have warnings especially in things outside of arch/. Doesn't
> matter why.
>
> The choices to fix are:
>
> - Override DTC_FLAGS in drivers/misc/. You can set DTC_FLAGS_lan966x_pci
>
> - Disable the check in dtc for overlays. We've done this for other cases.
>
> - Add enough info into the overlay to avoid the warnings. This might
> mean the overlay has to be applied up one node level. It is
> duplicating a few things which are in the base tree. This is my
> preference because it makes the overlay stand on its own. We'll have
> the same issue with dtschema checks too if we don't do this.
I see four more warnings that look like false positives to me:
drivers/misc/lan966x_pci.dtso:42.22-46.7: Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/cpu_clk: missing or empty reg/ranges property
drivers/misc/lan966x_pci.dtso:48.22-52.7: Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/ddr_clk: missing or empty reg/ranges property
drivers/misc/lan966x_pci.dtso:54.22-58.7: Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/sys_clk: missing or empty reg/ranges property
drivers/misc/lan966x_pci.dtso:18.15-165.5: Warning (avoid_unnecessary_addr_size): /fragment@0/__overlay__: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
Setting
DTC_FLAGS_lan966x_pci := -Wno-interrupts_property -Wno-simple_bus_reg -Wno-avoid_unnecessary_addr_size
silences them all.
regards
Philipp
