在 2024/10/24 08:27, Stephen Rothwell 写道:
Hi all,
After merging the btrfs tree, today's linux-next build (x86_64
allmodconfig) failed like this:
fs/btrfs/super.c: In function 'btrfs_reconfigure_for_mount':
fs/btrfs/super.c:2011:56: error: suggest parentheses around '&&' within '||' [-Werror=parentheses]
2011 | if (!fc->oldapi || !(fc->sb_flags & SB_RDONLY) && (mnt->mnt_sb->s_flags & SB_RDONLY))
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
Caused by commit
4642e430c55b ("btrfs: fix mount failure due to remount races")
My bad, in fact a new patch is going to remove the oldapi check
completely as newer mount using new API will break the per-subvolume
RO/RW again.
Thus a new patch is needed to remove the oldapi check first
(https://lore.kernel.org/linux-btrfs/e1a70aa6dd0fc9ba6c7050a5befb3bd5b75a1377.1729664802.git.wqu@xxxxxxxx/),
then the newer v2 patch
(https://lore.kernel.org/linux-btrfs/08e45ca0-5ed9-4684-940f-1e956a936628@xxxxxxx/T/#t)
will be completely fine.
Thanks,
Qu
I have used the btrfs tree from next-20241023 for today.
