On Mon, Sep 2, 2024 at 11:42 AM Arnaldo Carvalho de Melo
<acme@xxxxxxxxxx> wrote:
>
> On Mon, Sep 02, 2024 at 08:18:37AM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> > 387ad33e5410 ("perf test pmu: Set uninitialized PMU alias to null")
> >
> > Fixes tag
> >
> > Fixes: 3e0bf9 ("perf pmu: Restore full PMU name wildcard support")
>
> In the perf-tools-next I have it as:
>
> commit 37e2a19c98bf99747ca997be876dfc13f9165e0a
> Author: Veronika Molnarova <vmolnaro@xxxxxxxxxx>
> Date: Thu Aug 8 12:37:49 2024 +0200
>
> perf test pmu: Set uninitialized PMU alias to null
>
> Commit 3e0bf9fde2984469 ("perf pmu: Restore full PMU name wildcard
> support") adds a test case "PMU cmdline match" that covers PMU name
> wildcard support provided by function perf_pmu__match().
> <SNIP>
> Fixes: 3e0bf9fde2984469 ("perf pmu: Restore full PMU name wildcard support")
> Signed-off-by: Veronika Molnarova <vmolnaro@xxxxxxxxxx>
> Cc: James Clark <james.clark@xxxxxxxxxx>
> Cc: Michael Petlan <mpetlan@xxxxxxxxxx>
> Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> Cc: Radostin Stoyanov <rstoyano@xxxxxxxxxx>
> Link: https://lore.kernel.org/r/20240808103749.9356-1-vmolnaro@xxxxxxxxxx
> Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
Ok, you only updated perf-tools-next. I thought you did it on
perf-tools too. I'll update perf-tools soon.
>
> As I have:
>
> ⬢[acme@toolbox perf-tools-next]$ git config core.abbrev
> 16
> ⬢[acme@toolbox perf-tools-next]$
>
> And scripts to make sure we get enough resolution to avoid such problems
Sure, will do.
>
> I just checked and yeah, on perf-tools/perf-tools it is:
>
> Fixes: 3e0bf9 ("perf pmu: Restore full PMU name wildcard support")
> Signed-off-by: Veronika Molnarova <vmolnaro@xxxxxxxxxx>
> Cc: james.clark@xxxxxxx
> Cc: mpetlan@xxxxxxxxxx
> Cc: rstoyano@xxxxxxxxxx
> Link: https://lore.kernel.org/r/20240808103749.9356-1-vmolnaro@xxxxxxxxxx
> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
>
> So I suggest Namhyung fixes up the Fixes tag to have a longer prefix for
> the sha and Veronica to run:
>
> ⬢[acme@toolbox perf-tools]$ git config core.abbrev 16
> ⬢[acme@toolbox perf-tools]$ git config core.abbrev
> 16
> ⬢[acme@toolbox perf-tools]$
Yep, thanks!
Namhyung
>
> > has these problem(s):
> >
> > - Target SHA1 does not exist
> >
> > Actually, the quoted SHA1 is too short and is ambiguous in my tree:
> >
> > $ git show 3e0bf9
> > error: short object ID 3e0bf9 is ambiguous
> > hint: The candidates are:
> > hint: 3e0bf9fde298 commit 2024-06-26 - perf pmu: Restore full PMU name wildcard support
> > hint: 3e0bf93e0354 tree
> > fatal: ambiguous argument '3e0bf9': unknown revision or path not in the working tree.
> >
> > so you should use
> >
> > Fixes: 3e0bf9fde298 ("perf pmu: Restore full PMU name wildcard support")
> >
> > --
> > Cheers,
> > Stephen Rothwell
>
>
