AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxx> writes: > Il 18/06/24 12:03, AngeloGioacchino Del Regno ha scritto: >> Il 18/06/24 09:49, Julien Panis ha scritto: >>> On 6/17/24 18:44, Mark Brown wrote: >>>> Hi all, >>>> >>>> After merging the mediatek tree, today's linux-next build (arm64 >>>> defconfig) failed like this: >>>> >>>> /tmp/next/build/arch/arm64/boot/dts/rockchip/rk3568-wolfvision-pf5-display.dtsi:113.6-121.3: Warning (graph_port): /fragment@4/__overlay__: graph port node name should be 'port' >>>> Error: /tmp/next/build/arch/arm64/boot/dts/mediatek/mt8186.dtsi:2399.29-30 >>>> syntax error >>>> FATAL ERROR: Unable to parse input tree >>>> make[4]: *** [/tmp/next/build/scripts/Makefile.lib:431: >>>> arch/arm64/boot/dts/mediatek/mt8186-corsola-magneton-sku393216.dtb] Error 1 >>>> >>>> Caused by commit >>>> >>>> d7c1bde38bf37a5 ("arm64: dts: mediatek: mt8186: add default thermal zones") >>>> >>>> I have used the last version of the mediatek tree from 20240613 instead. >>> >>> Hello Mark, >>> >>> Here is the explanation: >>> https://lore.kernel.org/all/71d53ff6-fdae-440d-b60d-3ae6f0c881d9@xxxxxxxxxxxx/ >>> https://lore.kernel.org/all/6d9e0f19-9851-4f23-a8b8-6acc82ae7a3d@xxxxxxxxxxxx/ >>> >>> For some reason, the 2 first commits of the series were not applied >>> with the dts. These commits are needed because they contain some >>> definitions used by the dts. >>> >>> Julien >> >> I'm not sure how should I proceed here. >> > > Reiterating, I'm sure how should I proceed. You applied the dts patches but not the bindings, resulting in something that doesn't build because of changes to #defines in the bindings. Both of the bindings patches have already been acked by a DT maintainer (Connor), so you should just apply the bindings along with the DT patches. > I'm removing those patches from mediatek for-next until further notice. Rather than remove the DT patches, you should just apply the bindings patches. Kevin