Hi all, Today's linux-next merge of the block tree got a conflict in: io_uring/rw.c between commit: 80a07849c0b8 ("fs: claw back a few FMODE_* bits") from the vfs-brauner tree and commit: 40ffda3dc1a1 ("io_uring/rw: always setup io_async_rw for read/write requests") from the block tree. I fixed it up (see below) and can carry the fix as necessary. This is now fixed as far as linux-next is concerned, but any non trivial conflicts should be mentioned to your upstream maintainer when your tree is submitted for merging. You may also want to consider cooperating with the maintainer of the conflicting tree to minimise any particularly complex conflicts. -- Cheers, Stephen Rothwell diff --cc io_uring/rw.c index d9dfde1142a1,3134a6ece1be..000000000000 --- a/io_uring/rw.c +++ b/io_uring/rw.c @@@ -1021,13 -1003,13 +1004,13 @@@ int io_write(struct io_kiocb *req, unsi if (force_nonblock) { /* If the file doesn't support async, just async punt */ if (unlikely(!io_file_supports_nowait(req))) - goto copy_iov; + goto ret_eagain; - /* File path supports NOWAIT for non-direct_IO only for block devices. */ + /* Check if we can support NOWAIT. */ if (!(kiocb->ki_flags & IOCB_DIRECT) && - !(kiocb->ki_filp->f_mode & FMODE_BUF_WASYNC) && - (req->flags & REQ_F_ISREG)) + !(req->file->f_op->fop_flags & FOP_BUFFER_WASYNC) && + (req->flags & REQ_F_ISREG)) - goto copy_iov; + goto ret_eagain; kiocb->ki_flags |= IOCB_NOWAIT; } else {
Attachment:
pgpYCFNEgnv9e.pgp
Description: OpenPGP digital signature