On Tue, 26 Mar 2024 00:37:50 -0700 Suren Baghdasaryan <surenb@xxxxxxxxxx> wrote: > Patch [1] replaced vmalloc() function with a new definition but it did > not adjust the forward declaration used in UML architecture. Change it > to act as before. > Note that this prevents the vmalloc() allocations in __wrap_malloc() > from being accounted. If accounting here is critical, we will have > to remove this forward declaration and include vmalloc.h, however > that would pull in more dependencies and would require introducing more > architecture-specific headers, like asm/bug.h, asm/rwonce.h, etc. > This is likely the reason why this forward declaration was introduced > in the first place. > > [1] https://lore.kernel.org/all/20240321163705.3067592-31-surenb@xxxxxxxxxx/ > > Fixes: 576477564ede ("mm: vmalloc: enable memory allocation profiling") > Reported-by: SeongJae Park <sj@xxxxxxxxxx> > Signed-off-by: Suren Baghdasaryan <surenb@xxxxxxxxxx> Thank you for this fix, Suren. I confirmed that this patch fixes the issue I reported. Closes: https://lore.kernel.org/all/20240323180506.195396-1-sj@xxxxxxxxxx/ Tested-by: SeongJae Park <sj@xxxxxxxxxx> Thanks, SJ > --- > arch/um/include/shared/um_malloc.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/um/include/shared/um_malloc.h b/arch/um/include/shared/um_malloc.h > index 13da93284c2c..bf503658f08e 100644 > --- a/arch/um/include/shared/um_malloc.h > +++ b/arch/um/include/shared/um_malloc.h > @@ -11,7 +11,8 @@ > extern void *uml_kmalloc(int size, int flags); > extern void kfree(const void *ptr); > > -extern void *vmalloc(unsigned long size); > +extern void *vmalloc_noprof(unsigned long size); > +#define vmalloc(...) vmalloc_noprof(__VA_ARGS__) > extern void vfree(void *ptr); > > #endif /* __UM_MALLOC_H__ */ > -- > 2.44.0.396.g6e790dbe36-goog
