On Mon, Mar 25, 2024 at 10:44 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
>
>
> On 3/25/24 19:19, Suren Baghdasaryan wrote:
> > On Sun, Mar 24, 2024 at 6:36 PM Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> >>
> >> Hi all,
> >>
> >> After merging the mm tree, today's linux-next build (htmldocs) produced
> >> these warnings:
> >>
> >> include/linux/slab.h:545: warning: expecting prototype for kmem_cache_alloc(). Prototype was for kmem_cache_alloc_noprof() instead
> >> include/linux/slab.h:652: warning: expecting prototype for kmalloc(). Prototype was for kmalloc_noprof() instead
> >> include/linux/slab.h:692: warning: expecting prototype for kmalloc_array(). Prototype was for kmalloc_array_noprof() instead
> >> include/linux/slab.h:714: warning: expecting prototype for krealloc_array(). Prototype was for krealloc_array_noprof() instead
> >> include/linux/slab.h:730: warning: Function parameter or struct member '_n' not described in 'kcalloc'
> >> include/linux/slab.h:730: warning: Function parameter or struct member '_size' not described in 'kcalloc'
> >> include/linux/slab.h:730: warning: Function parameter or struct member '_flags' not described in 'kcalloc'
> >> include/linux/slab.h:730: warning: Excess function parameter 'n' description in 'kcalloc'
> >> include/linux/slab.h:730: warning: Excess function parameter 'size' description in 'kcalloc'
> >> include/linux/slab.h:730: warning: Excess function parameter 'flags' description in 'kcalloc'
> >> include/linux/slab.h:774: warning: expecting prototype for kzalloc(). Prototype was for kzalloc_noprof() instead
> >> mm/slab_common.c:1217: warning: expecting prototype for krealloc(). Prototype was for krealloc_noprof() instead
> >> mm/util.c:751: warning: expecting prototype for __vcalloc(). Prototype was for __vcalloc_noprof() instead
> >> mm/vmalloc.c:3897: warning: expecting prototype for vmalloc(). Prototype was for vmalloc_noprof() instead
> >> mm/vmalloc.c:3916: warning: expecting prototype for vmalloc_huge(). Prototype was for vmalloc_huge_noprof() instead
> >> mm/vmalloc.c:3953: warning: expecting prototype for vmalloc_user(). Prototype was for vmalloc_user_noprof() instead
> >> mm/mempool.c:245: warning: expecting prototype for mempool_init(). Prototype was for mempool_init_noprof() instead
> >> mm/mempool.c:271: warning: Function parameter or struct member 'gfp_mask' not described in 'mempool_create_node_noprof'
> >> mm/mempool.c:271: warning: Function parameter or struct member 'node_id' not described in 'mempool_create_node_noprof'
> >> mm/mempool.c:271: warning: expecting prototype for mempool_create_node(). Prototype was for mempool_create_node_noprof() instead
> >>
> >> Introduced by commits
> >>
> >> c64e38ed88d1 ("mm/slab: enable slab allocation tagging for kmalloc and friends")
> >> ea7b8933f21b ("mempool: hook up to memory allocation profiling")
> >> 576477564ede ("mm: vmalloc: enable memory allocation profiling")
> >>
> >> from the mm-unstable branch of the mm tree.
> >
> > Thanks for the report, Stephen!
> > Let us check with Randy Dunlap how we should handle these. I assume we
> > still want documentation to document kmalloc(), not kmalloc_noprof().
> > Maybe there is a way to mute these warnings.
>
> A proposed patch is here:
> https://lore.kernel.org/lkml/20240326054149.2121-1-rdunlap@xxxxxxxxxxxxx/T/#u
Thanks! I'll change back all the instances in the documentation where
we replaced original names with _noprof versions.
>
>
> --
> #Randy
