Hi all, Today's linux-next merge of the rpmsg tree got a conflict in: drivers/remoteproc/qcom_q6v5_adsp.c between commit: db34c47d56d5 ("remoteproc: qcom_q6v5_adsp: Convert to dev_pm_domain_attach|detach_list()") from Linus' tree and commit: 5789e877b93b ("remoteproc: qcom_q6v5_adsp: Use devm_rproc_alloc() helper") from the rpmsg tree. I fixed it up (see below) and can carry the fix as necessary. This is now fixed as far as linux-next is concerned, but any non trivial conflicts should be mentioned to your upstream maintainer when your tree is submitted for merging. You may also want to consider cooperating with the maintainer of the conflicting tree to minimise any particularly complex conflicts. -- Cheers, Stephen Rothwell diff --cc drivers/remoteproc/qcom_q6v5_adsp.c index 93f9a1537ec6,34ac996a93b2..000000000000 --- a/drivers/remoteproc/qcom_q6v5_adsp.c +++ b/drivers/remoteproc/qcom_q6v5_adsp.c @@@ -704,13 -713,15 +704,13 @@@ static int adsp_probe(struct platform_d ret = adsp_init_clock(adsp, desc->clk_ids); if (ret) - goto free_rproc; + return ret; - ret = qcom_rproc_pds_attach(adsp->dev, adsp, - desc->proxy_pd_names); + ret = qcom_rproc_pds_attach(adsp, desc->pd_names, desc->num_pds); if (ret < 0) { dev_err(&pdev->dev, "Failed to attach proxy power domains\n"); - goto free_rproc; + return ret; } - adsp->proxy_pd_count = ret; ret = adsp_init_reset(adsp); if (ret) @@@ -742,11 -753,8 +742,8 @@@ return 0; disable_pm: - qcom_rproc_pds_detach(adsp, adsp->proxy_pds, adsp->proxy_pd_count); + qcom_rproc_pds_detach(adsp); - free_rproc: - rproc_free(rproc); - return ret; } @@@ -760,8 -768,7 +757,7 @@@ static void adsp_remove(struct platform qcom_remove_glink_subdev(adsp->rproc, &adsp->glink_subdev); qcom_remove_sysmon_subdev(adsp->sysmon); qcom_remove_ssr_subdev(adsp->rproc, &adsp->ssr_subdev); - qcom_rproc_pds_detach(adsp, adsp->proxy_pds, adsp->proxy_pd_count); + qcom_rproc_pds_detach(adsp); - rproc_free(adsp->rproc); } static const struct adsp_pil_data adsp_resource_init = {
Attachment:
pgpcsIXvtP8BQ.pgp
Description: OpenPGP digital signature